[docs-beta] rm comment in dockerfile as is invalid syntax #26272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be really nice if we had the https://github.com/dagster-io/dagster/tree/master/examples/deploy_docker |
|
I've updated the https://github.com/dagster-io/dagster/pull/26275/files We should consolidate this guide, and this example. |
neverett
reviewed
Dec 13, 2024
neverett
approved these changes
Dec 13, 2024
cmpadden
force-pushed
the
colton/fix-docker-tutorial
branch
from
b61b835 to
b335bfd
Compare
|
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-ctmpaumw0-elementl.vercel.app Direct link to changed pages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
It is invalid syntax to have a comment after a
\in your Dockerfile.How I Tested These Changes
Ran locally.
Changelog